Date: Fri, 05 Apr 2013 14:22:36 -0700 From: Sean Bruno <seanwbruno@gmail.com> To: Mark Johnston <markj@freebsd.org> Cc: freebsd-scsi@freebsd.org Subject: Re: adding BBU relearn support to mfiutil Message-ID: <1365196956.17311.13.camel@localhost> In-Reply-To: <20130304033836.GA33631@oddish> References: <20130304033836.GA33631@oddish>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, 2013-03-03 at 22:38 -0500, Mark Johnston wrote: > Hi Everyone, > > I recently needed to add a couple of features to mfiutil related to BBU > relearning. I've pasted a patch below which > > 1. adds extra fields to the output of "mfiutil show battery" showing BBU > properties. This is essentially the output of > > # MegaCli -AdpBbuInfo -GetBbuProperties -aLL > > and consists of info about battery learning: the learn period, the > time at which the controller will start the next relearn, and the BBU > mode (which indicates whether the battery supports transparent > relearning). > > 2. adds a couple of subcommands under "mfiutil bbu" which lets users set > the BBU properties which can be set by MegaCli. > > 3. adds a command "mfiutil start learn" which immediately kicks off a > battery relearn. > > These changes grew out of concern about the fact that the controller > write cache is set to write-through mode during a relearn period (which > usually lasts for several hours). This ended up causing some mysterious > and intermittent performance issues, so I needed a way of getting more > info about what was going on (using MegaCli isn't really an option for > several reasons). Some BBUs support transparent relearning, which > basically means that the controller write cache doesn't get turned off > during a relearn. However, LSI's default config doesn't enable it, and > now mfiutil can be used to do that (through "mfiutil bbu bbu-mode"). > > I was hoping someone would be able to review the patch. If anyone's able > and willing to test it, I'd very much appreciate feedback from that. > > Thanks! > -Mark Just to document for the record. Finally got around to testing this today with Mark providing updates. Looks good overall with a couple of nits that he is handling at the moment (man page and variable name collision). Sean [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iQEcBAABAgAGBQJRX0CcAAoJEBkJRdwI6BaHXqYH/37KVK+hCK/SzyK2BiGYK+AU iIab4boLwgzCWZr7fYtQwHfyngVwrwubC6grhAsyw6eDdodmKFosTZT1ZPEsXtyW JCUasWrpppxvo+HyaIF708ZlKHVX5V7O+yG2gx5IBM61DkXnh69D9hcn+hiqFU3I vHcvzpZi24gjxL2fH2fXro9RO3Ng0ctQlqW3dvirFtsV04por0XglvDO35hH47m6 wRWL4zNqiO2mbGg2u6ou3RtbwRZdBKJSFn4s9Fi766LX0+q/amwFAMt2hreXGr8M AoSPhvjtPVKulHwvMYamrmePjB8WbrN4YEu+F4YhnQe9abRj7ZELj8OwY9W4oi8= =Bfrb -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1365196956.17311.13.camel>