Date: Wed, 11 Mar 2026 13:40:08 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: Roman Bogorodskiy <novel@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, dev-commits-ports-all@FreeBSD.org Subject: Re: git: ce3d0cc5945e - main - devel/libvirt: enable BHYVE option on arm64 Message-ID: <1365758089.1058.1773232808980@localhost> In-Reply-To: <69b15c4e.211a9.177820f6@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi, The commit of this line says that bhyveload is needed during the build and that is why it checks for it. https://cgit.freebsd.org/ports/commit/devel/libvirt/Makefile?id=751fd2a4a2fcd48fc1f80b1a2d20848f35a924a3 Your commit message does not hint on if bhyveload is not needed for the build anymore. Can you elaborate a little on this? Or point to the change in libvirt that makes it not use bhyveload anymore? NB: I totally trust that you compiled and checked the port on aarch64. So the cause is probably fixed upstream. It would just very nicely close the documentation loop if the commit referred to that fix in libvirt. Regards, Ronald. Van: Roman Bogorodskiy <novel@FreeBSD.org> Datum: woensdag, 11 maart 2026 13:13 Aan: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Onderwerp: git: ce3d0cc5945e - main - devel/libvirt: enable BHYVE option on arm64 > > The branch main has been updated by novel: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ce3d0cc5945ee374d845ae16351999d43ca7cd42 > > commit ce3d0cc5945ee374d845ae16351999d43ca7cd42 > Author: Roman Bogorodskiy <novel@FreeBSD.org> > AuthorDate: 2026-03-10 17:14:30 +0000 > Commit: Roman Bogorodskiy <novel@FreeBSD.org> > CommitDate: 2026-03-11 12:11:25 +0000 > > devel/libvirt: enable BHYVE option on arm64 > > Currently, the BHYVE option is available only if "/usr/sbin/bhyveload" > is present. However, bhyveload(8) is not present on arm64. > To make the BHYVE option available on arm64 too, update > the condition to check for the "/usr/sbin/bhyve" path instead. > > Sponsored by: The FreeBSD Foundation > --- > devel/libvirt/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devel/libvirt/Makefile b/devel/libvirt/Makefile > index 9ef329749e89..5520a090820b 100644 > --- a/devel/libvirt/Makefile > +++ b/devel/libvirt/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= libvirt > DISTVERSION= 12.1.0 > +PORTREVISION= 1 > CATEGORIES= devel > MASTER_SITES= http://libvirt.org/sources/ \ > ftp://libvirt.org/libvirt/ > @@ -22,7 +23,7 @@ RUN_DEPENDS= dnsmasq:dns/dnsmasq > OPTIONS_DEFINE= DOCS NLS NSS QEMU READLINE SASL SLIRP LIBSSH LIBSSH2 ZFS > OPTIONS_DEFAULT= READLINE LIBSSH LIBSSH2 ZFS > OPTIONS_DEFINE_amd64= XEN > -.if exists(/usr/sbin/bhyveload) > +.if exists(/usr/sbin/bhyve) > OPTIONS_DEFINE+= BHYVE > OPTIONS_DEFAULT+= BHYVE SLIRP > .else > > > > [-- Attachment #2 --] <html><head></head><body>Hi,<br> <br> The commit of this line says that bhyveload is needed during the build and that is why it checks for it.<br> <a href="https://cgit.freebsd.org/ports/commit/devel/libvirt/Makefile?id=751fd2a4a2fcd48fc1f80b1a2d20848f35a924a3">https://cgit.freebsd.org/ports/commit/devel/libvirt/Makefile?id=751fd2a4a2fcd48fc1f80b1a2d20848f35a924a3</a><br>; <br> Your commit message does not hint on if bhyveload is not needed for the build anymore.<br> Can you elaborate a little on this? Or point to the change in libvirt that makes it not use bhyveload anymore?<br> <br> NB: I totally trust that you compiled and checked the port on aarch64. So the cause is probably fixed upstream. It would just very nicely close the documentation loop if the commit referred to that fix in libvirt.<br> <br> Regards,<br> Ronald.<br> <br> <p><strong>Van:</strong> Roman Bogorodskiy <novel@FreeBSD.org><br> <strong>Datum:</strong> woensdag, 11 maart 2026 13:13<br> <strong>Aan:</strong> ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org<br> <strong>Onderwerp:</strong> git: ce3d0cc5945e - main - devel/libvirt: enable BHYVE option on arm64</p> <blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px"> <div class="MessageRFC822Viewer" id="P"> <div class="TextPlainViewer" id="P.P">The branch main has been updated by novel:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=ce3d0cc5945ee374d845ae16351999d43ca7cd42">https://cgit.FreeBSD.org/ports/commit/?id=ce3d0cc5945ee374d845ae16351999d43ca7cd42</a><br>; <br> commit ce3d0cc5945ee374d845ae16351999d43ca7cd42<br> Author: Roman Bogorodskiy <novel@FreeBSD.org><br> AuthorDate: 2026-03-10 17:14:30 +0000<br> Commit: Roman Bogorodskiy <novel@FreeBSD.org><br> CommitDate: 2026-03-11 12:11:25 +0000<br> <br> devel/libvirt: enable BHYVE option on arm64<br> <br> Currently, the BHYVE option is available only if "/usr/sbin/bhyveload"<br> is present. However, bhyveload(8) is not present on arm64.<br> To make the BHYVE option available on arm64 too, update<br> the condition to check for the "/usr/sbin/bhyve" path instead.<br> <br> Sponsored by: The FreeBSD Foundation<br> ---<br> devel/libvirt/Makefile | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br> <br> diff --git a/devel/libvirt/Makefile b/devel/libvirt/Makefile<br> index 9ef329749e89..5520a090820b 100644<br> --- a/devel/libvirt/Makefile<br> +++ b/devel/libvirt/Makefile<br> @@ -1,5 +1,6 @@<br> PORTNAME= libvirt<br> DISTVERSION= 12.1.0<br> +PORTREVISION= 1<br> CATEGORIES= devel<br> MASTER_SITES= <a href="http://libvirt.org/sources/">http://libvirt.org/sources/</a>; \<br> ftp://libvirt.org/libvirt/<br>; @@ -22,7 +23,7 @@ RUN_DEPENDS= dnsmasq:dns/dnsmasq<br> OPTIONS_DEFINE= DOCS NLS NSS QEMU READLINE SASL SLIRP LIBSSH LIBSSH2 ZFS<br> OPTIONS_DEFAULT= READLINE LIBSSH LIBSSH2 ZFS<br> OPTIONS_DEFINE_amd64= XEN<br> -.if exists(/usr/sbin/bhyveload)<br> +.if exists(/usr/sbin/bhyve)<br> OPTIONS_DEFINE+= BHYVE<br> OPTIONS_DEFAULT+= BHYVE SLIRP<br> .else<br> </div> <hr></div> </blockquote> <br> </body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1365758089.1058.1773232808980>