Date: Fri, 16 Jun 2006 10:51:32 -0600 From: John Hein <jhein@timing.com> To: Daichi GOTO <daichi@freebsd.org> Cc: freebsd-fs@freebsd.org Subject: Re: [ANN] unionfs patchset-14 release Message-ID: <17554.57748.372948.664580@gromit.timing.com> In-Reply-To: <44926377.5000005@freebsd.org> References: <44926377.5000005@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At first I looked at fixing the wording for the deprecation of -r
like so:
--- mount_unionfs.c.patchset-14 Fri Jun 16 10:27:35 2006
+++ mount_unionfs.c Fri Jun 16 10:23:00 2006
@@ -95,8 +95,8 @@
switch (ch) {
case 'r':
errno = EOPNOTSUPP;
- perror("option '-r' cannot already be used."
- "you should use nullfs instead.");
+ perror("Option '-r' is no longer available. "
+ "You should use nullfs instead");
break;
case 'b':
iov[iovcnt].iov_base = "below";
But then I thought that it would be even better to just drop it
altogether (and perhaps add a note to UPDATING) like so:
--- mount_unionfs.c.patchset-14 Fri Jun 16 10:27:35 2006
+++ mount_unionfs.c Fri Jun 16 10:30:41 2006
@@ -91,13 +91,8 @@
iovcnt = 6;
mntflags = 0;
- while ((ch = getopt(argc, argv, "brc:o:m:M:u:g:")) != -1) {
+ while ((ch = getopt(argc, argv, "bc:o:m:M:u:g:")) != -1) {
switch (ch) {
- case 'r':
- errno = EOPNOTSUPP;
- perror("option '-r' cannot already be used."
- "you should use nullfs instead.");
- break;
case 'b':
iov[iovcnt].iov_base = "below";
iov[iovcnt].iov_len = strlen(iov[iovcnt].iov_base) + 1;
Then reword the text in the man page about the deprecation. It's
wrong anyway since it says -r is available for "backward
compatibility". To reflect the patchset-14 version accurately, it
should really say that it is ignored.
I would just remove -r from mount_unionfs.c. Then, in the man page,
perhaps move the discussion about its removal to the HISTORY section
(in addition to some brief words about this rewrite as an evolutionary
milestone).
Thanks for the good work.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17554.57748.372948.664580>