Date: Mon, 18 Sep 1995 14:11:06 -0700 (MST) From: Terry Lambert <terry@lambert.org> To: kuku@gilberto.physik.RWTH-Aachen.DE Cc: julian@freefall.freebsd.org, hackers@freefall.freebsd.org Subject: Re: why is this not a bug in namei? Message-ID: <199509182111.OAA08650@phaeton.artisoft.com> In-Reply-To: <199509180843.KAA08948@gilberto.physik.RWTH-Aachen.DE> from "Christoph Kukulies" at Sep 18, 95 10:43:12 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > free(cnp->cn_pnbuf, M_NAMEI);
> ^^^^
> Is this just a typo? Shouldn't it be a FREE() macro like below?
> > [...]
> > if (error) {
> > FREE(cnp->cn_pnbuf, M_NAMEI);
> > return (error);
No this is actually the code.
The code is screwed, but it only shows if KMEMSTATS and DIAGNOSTIC are
both undefined (see /sys/sys/malloc.h).
David (?) said he'd go through and mung malloc.h so it wasn't broken
(the non-KMEMSTATS case is an instance of legacy code in malloc.h).
The code should still be cleaned up, however.
I prefer the macroized version to allow later instrumentation.
The access to the system clock timeval should be similarly macroized
for atomicity of access reasons (vnode times update).
Terry Lambert
terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509182111.OAA08650>