Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Apr 1997 05:06:03 -0500 (EST)
From:      Peter Dufault <dufault@hda.com>
To:        current@freebsd.org
Subject:   Breaking the lkm DISPATCH macro
Message-ID:  <199704051006.FAA08421@hda.hda.com>

next in thread | raw e-mail | index | archive | help
Heads up:

I'm about to break LKM's DISPATCH macro by passing in the name
argument.  LKM's are broken in -current for MOD_DEV, and in fixing
them I want to eliminate the static _module structure by prepending
the name.

This can't be done compatably (without cruft like feature test macros)
since DISPATCH uses _module directly and the new MOD_DECL functions
will prepend the name.

The interface change will require changing DISPATCH to
MOD_DISPATCH (gratuitous for consistency with the other macros)
and passing the name in.  I'm keeping a DISPATCH macro there to
generate an error that leads back to the header to see what changed.

I've fixed the code in the tree but user LKMs in -current will break.
They're already broken in -current versus non -current since the name
argument has changed from a string to an identifier so I think that
is a minor issue.

Bruce reviewed the changes.

-- 
Peter Dufault (dufault@hda.com)   Realtime Machine Control and Simulation
HD Associates, Inc.               Voice: 508 433 6936



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704051006.FAA08421>