Date: Sun, 18 Jan 1998 13:42:42 -0800 From: Paul Traina <pst@juniper.net> To: Bruce Evans <bde@zeta.org.au> Cc: bde@FreeBSD.ORG, dg@FreeBSD.ORG, hackers@FreeBSD.ORG Subject: Re: isdisk() kludge in kernel Message-ID: <199801182142.NAA08748@red.juniper.net> In-Reply-To: Your message of "Sun, 18 Jan 1998 14:29:57 %2B1100." <199801180329.OAA13387@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199801180329.OAA13387@godzilla.zeta.org.au>, Bruce Evans writes: > >I was looking at isdisk and wanted to hurl chunks. > > > >This is used by spec_open to determine if we should be allowed to open a > >disk device when securelevel >= 1. > > It isn't even used in -current. I think it is, the flag gets set elsewhere. > >I'd like to propose changing spec_open to simply NEVER allowing the open of > >a block device, or character device, if a character device has a block > >device associated with it and eliminate isdisk() in kern_conf entirely. > > This would break at least backups to SCSI tape devices, since st has both > block and character devices, but tapes aren't disks. Perhaps the broken > version is correct - isdisk() really means isasecurityholeifmountable(). Aha, you're correct, ok, bad idea. > > Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801182142.NAA08748>