Date: Tue, 01 Dec 1998 21:45:42 -0800 From: David Greenman <dg@root.com> To: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru> Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: mmap of large files Message-ID: <199812020545.VAA03985@root.com> In-Reply-To: Your message of "Wed, 02 Dec 1998 03:21:11 %2B0300." <199812020021.DAA00861@tejblum.dnttm.rssi.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
>Does the test > if ((pos + size > (vm_offset_t)-PAGE_SIZE) || >in the mmap syscall have any purpose, other than break mmap with >pos > 4GB? I think the code is wrong. I think it should be (addr + size) and comparing against -PAGE_SIZE is probably also wrong - careful attention needs to be paid to rounding and overflow issues here. Needs more analysis. -DG David Greenman Co-founder/Principal Architect, The FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812020545.VAA03985>