Date: Sat, 18 Sep 1999 22:31:36 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Julian Elischer <julian@whistle.com>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/vn vn.c Message-ID: <199909190531.WAA68523@apollo.backplane.com> References: <13144.937692636@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
:In message <Pine.BSF.4.05.9909181455490.19879-100000@home.elischer.org>, Julian : Elischer writes: :>Poul-Henning, since Matt (who is working on this driver) STATED that he :>didn't want you to do this, why did you do it anyway? : :Uhm, I read your last message as your approval for this... : :>If you want to do this right.. :> :>Move the calculation of blocksize in spec_read and spec_write :>to spec_open, and store the value in to si_bsize_best if it's still unset, :>and then in read/write just blindly use _best, instead of doing the :>calculation on every read and write. : :I think si_bsize_best should not even be used in spec_read/_write. : :I think they should blindly use max(PAGE_SIZE, si_bsize_phys). : :-- :Poul-Henning Kamp FreeBSD coreteam member Considering that you knew there was a dispute, and especially considering that you knew that I was considering making the default larger, not removing it, you should not have made that commit. However, I am willing to give you the benefit of the doubt this time around on the assumption that it will not happen again. Since I've pretty much been the person who has made the VN device useful again over the last 6 months, I should probably be considered to be the current maintainer on it. Please make no further commits to the VN device without running them past me first. -Matt Matthew Dillon <dillon@backplane.com> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909190531.WAA68523>