Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Feb 2023 23:46:21 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Paul Mather <paul@gromit.dlib.vt.edu>
Cc:        FreeBSD User <freebsd@walstatt-de.de>, FreeBSD CURRENT <freebsd-current@freebsd.org>
Subject:   Re: NanoBSD: CURRENT unable to compile 13-STABLE : error: a function definition without a prototype is deprecated ... in C
Message-ID:  <1F3F20A1-C2BC-4A33-ABFD-D20F4ADB67E8@FreeBSD.org>
In-Reply-To: <720721A7-B1ED-405B-98EB-04A3AFCA7FD5@gromit.dlib.vt.edu>
References:  <20230227192011.08f7aa8e@thor.intern.walstatt.dynvpn.de> <E2AFBCE9-4467-4E75-B7E4-4C6E0B03C0AA@FreeBSD.org> <720721A7-B1ED-405B-98EB-04A3AFCA7FD5@gromit.dlib.vt.edu>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_C4B76800-750C-4437-B591-C769C537FFF4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 27 Feb 2023, at 22:23, Paul Mather <paul@gromit.dlib.vt.edu> wrote:
>=20
> On Feb 27, 2023, at 2:57 PM, Dimitry Andric <dim@FreeBSD.org> wrote:
>=20
>> On 27 Feb 2023, at 19:19, FreeBSD User <freebsd@walstatt-de.de> =
wrote:
>>>=20
>>> Running recent CURRENT as host (FreeBSD 14.0-CURRENT #23 =
main-n261147-b8bb73ab724b: Sun Feb 26
>>> 17:39:38 CET 2023 amd64), and nanoBSD (recent 13-STABLE, git =
stable/13).
>>>=20
>>> Building an appliance based on 13-STABLE sources, a customized =
kernel via nanoBSD, since a
>>> couple of weeks for now building the sources fails in kernel =
sources:
>>>=20
>>> [...]
>>> --- modules-all ---
>>> --- all_subdir_an ---
>>> =
/pool/home/ohartmann/Projects/router/router/apu2c4/src/sys/dev/an/if_an_pc=
i.c:143:1: error: a
>>> function definition without a prototype is deprecated in all =
versions of C and is not
>>> supported in C2x [-Werror,-Wdeprecated-non-prototype]
>>> [..]
>>>=20
>>> Disabling all wireless options in the kernel config starts dropping =
errors of a similar kind
>>> on other kernel places.
>>>=20
>>> Compiling on FBSD 13-STABLE seems to be all right.
>>>=20
>>> Can this be fixed. please? What causes the error and how can this be =
resolved if the subtree
>>> of FreeBSD's sources is a submodule?
>>=20
>> Not sure what you mean with "subtree is a submodule", but this is =
likely
>> caused by skipping the cross-tools stage somehow. Do you have any
>> specific make.conf or src.conf settings for that?
>=20
>=20
> I got bitten by this recently.  In my case, it was Poudriere (running =
on 14-CURRENT) trying to build a 13-STABLE jail.  The Poudriere jail's =
"src.conf" was taken from the actual system for which Poudriere builds =
packages.  It had (amongst others) these two options:
>=20
> WITH_SYSTEM_COMPILER=3Dyes
> WITHOUT_CROSS_COMPILER=3Dyes
>=20
>=20
> When I commented these out in the jail-src.conf Poudriere file the =
jail built correctly.
>=20
> I figure the system built fine because its system compiler is LLVM =
14.x.  The Poudriere system compiler is LLVM 15.x, which has the =
breaking change wrt. old-style prototypes.

Yes, that is what I suspected in Oliver's case: if you skip the
cross-tools stage in a buildworld of stable/13 on a 14-CURRENT host, by
setting WITH_SYSTEM_COMPILER, you are bound to run into compilation
errors that have been fixed in 14-CURRENT, but not yet MFC'd.

The safest solution is to let cross-tools do its thing, which will check
the host compiler, and automatically build an appropriate version of the
compiler and linker for the stable branch, if required.

That said, I will be merging clang 15.0.7 and a bunch of other things
that should solve all these errors to stable/13 at some point, but not
before the 13.2-RELEASE is out. This is to avoid making life more
difficult for our release engineering team.

-Dimitry


--Apple-Mail=_C4B76800-750C-4437-B591-C769C537FFF4
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY/0yvQAKCRCwXqMKLiCW
o2u/AJ4ku5kfQDoBxldq8vtZ0JPIewxJKwCfaHkCzxLC53ZHTXfB6fI1CwFOyKg=
=BqFr
-----END PGP SIGNATURE-----

--Apple-Mail=_C4B76800-750C-4437-B591-C769C537FFF4--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1F3F20A1-C2BC-4A33-ABFD-D20F4ADB67E8>