Date: Sun, 30 Apr 2000 11:23:44 -0700 From: "Andrey A. Chernov" <ache@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <20000430112344.A13987@freebsd.org> In-Reply-To: <Pine.BSF.4.21.0005010354410.2953-100000@alphplex.bde.org>; from bde@zeta.org.au on Mon, May 01, 2000 at 04:11:56AM %2B1000 References: <200004301600.JAA18945@freefall.freebsd.org> <Pine.BSF.4.21.0005010354410.2953-100000@alphplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 01, 2000 at 04:11:56AM +1000, Bruce Evans wrote: > This is all very broken. It used to be possible to set the drainwait timeout > using comcontrol and have the setting live across closes. /etc/rc.serial > has examples of setting it. Now, the setting gets clobbered in ttyopen() > not only for first opens, but for open of the termios line discipline, i.e., > for every open(2) and for every reentry to the termios line discipline > (TIOCSETD to TTYDISC). This bug was introduced in the previous commit. > The sysctl just allows changing the default value that is used to clobber > the setting. BTW, you say nothing when I send initial patch for review. Probably ttyopen not the best place for setting t_timeout to its default value. What place you suggest as better one? > Sysctls shouldn't be used in device drivers. Here the default should only > be used if the timeout has not already been set. Changing the default > using sysctl will have little or no effect effect after the system has > warmed up, since most or all ttys will have had their timeouts set. I disagree. 1) This sysctl supposed to be called early in rc.sysctl, before any tty device comes up. 2) You forget about ptys which are open/closed often, it is needed mainly for them (hanging TCP connections) 3) In current variant (with ttyopen), even ttyv* change timeout after loggin out. -- Andrey A. Chernov <ache@nagual.pp.ru> http://nagual.pp.ru/~ache/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000430112344.A13987>