Date: Thu, 7 Dec 2000 17:34:53 -0500 From: Christopher Masto <chris@netmonger.net> To: "Daniel C. Sobral" <dcs@newsguy.com>, Alfred Perlstein <alfred@FreeBSD.ORG> Cc: Daniel Eischen <eischen@vigrid.com>, "David O'Brien" <obrien@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm phys_pager.c Message-ID: <20001207173453.A18103@netmonger.net> In-Reply-To: <3A2EFBC4.EE8D90B1@newsguy.com>; from Daniel C. Sobral on Thu, Dec 07, 2000 at 11:53:56AM %2B0900 References: <20001205145908.K8051@fw.wintelcom.net> <Pine.SUN.3.91.1001205180108.24320A-100000@pcnet1.pcnet.com> <20001205152054.M8051@fw.wintelcom.net> <3A2EFBC4.EE8D90B1@newsguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 07, 2000 at 11:53:56AM +0900, Daniel C. Sobral wrote:
> Alfred Perlstein wrote:
> >
> > And who exactly would bump into this problem except me?
>
> God, how many times was the world broken because of a mistake during
> commit, a missing file, a different version being committed than the one
> intended, a last minute addition that couldn't possibly go wrong (and
> was anyway), etc?
>
> I'm about to violate mailing lists charter, but I think it is
> appropriate here.
object = vm_object_allocate(OBJT_PHYS,
- OFF_TO_IDX(foff + size));
+ OFF_TO_IDX(foff + PAGE_MASK + size));
Honestly, this thread is ridiculous. If the code didn't work in the
first place, AND nobody noticed because it's so rarely used, AND the
change is _obviously_ trivial, then what's the problem here? "stable"
is not "immobile".
Even if this fix was wrong (and apparently it was), it doesn't change
the fact that it was:
1. A fix for code that was known to be unusably broken
2. Extremely unlikely to hurt anything (esp. given #1)
3. Extremely unlikely to break the world (obvious by inspection)
4. Trivially reversible
You've got the right argument, but you've picked the wrong example
to apply it to. There has to be _some_ flexibility in the rules,
and it would be hard to find a better example of where "shakeout
in -current" has no value.
--
Christopher Masto Senior Network Monkey NetMonger Communications
chris@netmonger.net info@netmonger.net http://www.netmonger.net
Free yourself, free your machine, free the daemon -- http://www.freebsd.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001207173453.A18103>