Date: Fri, 8 Dec 2000 23:24:03 +0100 From: Wilko Bulte <wkb@freebie.demon.nl> To: Bill Paul <wpaul@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, alpha@freebsd.org Subject: Re: cvs commit: src/sys/alpha/conf GENERIC Message-ID: <20001208232403.A1471@freebie.demon.nl> In-Reply-To: <20001208212728.9D8D737B400@hub.freebsd.org>; from wpaul@freebsd.org on Fri, Dec 08, 2000 at 01:27:28PM -0800 References: <XFMail.001208131116.jhb@FreeBSD.org> <20001208212728.9D8D737B400@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 08, 2000 at 01:27:28PM -0800, Bill Paul wrote: > Ok. There's something about the way the descriptor memory is being > allocated that I don't like. I can't quite put my finger on what it > is. I usually resort to contigmalloc() when I allocate descriptor > space; it's not always necessary but it helps me sleep at night. Plus > you know you're getting memory that's aligned on the right boundary. > > Wilko: please try me the following patch to if_tx.c. In addition to > tweaking the descriptor allocation, I added some code to force the > proper payload alignment on received packets. I'm not positive, but > I think you need this for this chip too. Looks like I lack a .h somewhere: mx5# make cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mno-fp-regs -Wa,-mev56 ../../pci/if_tx.c ../../pci/if_tx.c: In function `epic_rx_done': ../../pci/if_tx.c:930: `ETHER_ALIGN' undeclared (first use in this function) ../../pci/if_tx.c:930: (Each undeclared identifier is reported only once ../../pci/if_tx.c:930: for each function it appears in.) *** Error code 1 Note that I'm testing on 4.2R at the moment. No -current for me on this alpha at the moment. -- Wilko Bulte Arnhem, the Netherlands wilko@freebsd.org http://www.freebsd.org http://www.nlfug.nl To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001208232403.A1471>