Date: Mon, 4 Jun 2001 02:28:40 +0200 From: Jesper Skriver <jesper@skriver.dk> To: Bruce Evans <bde@zeta.org.au> Cc: Warner Losh <imp@village.org>, Michael Harnois <mdharnois@home.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_accf.c uipc_mbuf.c uipc_socket2.c src/sys/netinet ip_input.c src/sys/netinet6 in6_proto.c src/sys/sys param.h Message-ID: <20010604022840.A50666@skriver.dk> In-Reply-To: <Pine.BSF.4.21.0106040941090.53000-100000@besplex.bde.org>; from bde@zeta.org.au on Mon, Jun 04, 2001 at 09:56:45AM %2B1000 References: <20010601102422.D23169@skriver.dk> <Pine.BSF.4.21.0106040941090.53000-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 04, 2001 at 09:56:45AM +1000, Bruce Evans wrote: > On Fri, 1 Jun 2001, Jesper Skriver wrote: > > > On Fri, Jun 01, 2001 at 10:14:25AM +0200, Jesper Skriver wrote: > > > On Thu, May 31, 2001 at 07:03:56PM -0600, Warner Losh wrote: > > > > In message <868zjdjatx.fsf@mharnois.workgroup.net> Michael Harnois writes: > > > > : cc -O -pipe -march=pentiumpro -Wall -I/usr/obj/usr/src/i386/usr/include -c /usr/src/games/fortune/strfile/strfile.c > > > > : In file included from /usr/src/games/fortune/strfile/strfile.c:54: > > > > : /usr/include/sys/param.h:236: opt_param.h: No such file or directory > > > > > > > > Ah, the classic "I included opt_foo.h from a file that was exported to > > > > userland" problem. > > > > > > Bummer, I don't have time to fix it right now (probably put it in > > > a new .h file), so I'll back it out for now, and have a second go > > > when I have more time. > > > > http://people.FreeBSD.org/~jesper/opt_param.diff > > > > Should fix this, it moved NMBCLUSTERS back to > > src/sys/kern/uipc_mbuf.c, revert <sys/param.h> to the old version, > > and sets the default value for net.inet.ip.maxfragpackets and > > net.inet6.ip6.maxfragpackets to 200 instead of NMBCLUSTERS/4 > > I think you want it to be (nmbclusters / 4) Yes, but the initial value for a sysctl has to be a constant, or atleast it won't compile unless it is, Andrew Gallatin has suggested something like SYSINIT(frag, SI_SUB_MBUF, SI_ORDER_ANY, nfraginit, NULL) static void nfraginit(void *dummy) { ip_nfragpackets = nmbclusters/4; } Which I need to read more on and understand, so for now I committed it with a fixed default value of 200. > not NMBCLUSTERS/4. The variables in param.c are supposed to actually > be variables (it is always possible to change them by patching > the binary, even if they are not boot-time tunables). Using the > compile-time constants for secondary variables just gives wrong values > if the primary variables are changed, or more variables to patch/tune > manually. /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: FreeBSD committer @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010604022840.A50666>