Date: Fri, 31 Aug 2001 16:04:14 -0400 From: David Hill <david@phobia.ms> To: audit@freebsd.org Subject: users.c PATCH - please review Message-ID: <20010831160414.7125e88e.david@phobia.ms>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hello -
I have patched users/users.c so that it will compile under WARNS?=2. I have both attached and cut/pasted it to the message.
Please review it.
Thanks
- David Hill
diff -ru /usr/src/usr.bin/users.orig/Makefile /usr/src/usr.bin/users/Makefile
--- /usr/src/usr.bin/users.orig/Makefile Fri May 27 08:33:16 1994
+++ /usr/src/usr.bin/users/Makefile Fri Aug 31 15:57:39 2001
@@ -1,5 +1,6 @@
# @(#)Makefile 8.1 (Berkeley) 6/6/93
PROG= users
+WARNS?= 2
.include <bsd.prog.mk>
diff -ru /usr/src/usr.bin/users.orig/users.c /usr/src/usr.bin/users/users.c
--- /usr/src/usr.bin/users.orig/users.c Fri Aug 27 21:07:14 1999
+++ /usr/src/usr.bin/users/users.c Fri Aug 31 15:58:20 2001
@@ -117,5 +117,8 @@
scmp(p, q)
const void *p, *q;
{
- return(strncmp((char *)p, (char *)q, UT_NAMESIZE));
+ const char *const pp1 = p;
+ const char *const pp2 = q;
+
+ return(strncmp(pp1, pp2, UT_NAMESIZE));
}
[-- Attachment #2 --]
diff -ru /usr/src/usr.bin/users.orig/Makefile /usr/src/usr.bin/users/Makefile
--- /usr/src/usr.bin/users.orig/Makefile Fri May 27 08:33:16 1994
+++ /usr/src/usr.bin/users/Makefile Fri Aug 31 15:57:39 2001
@@ -1,5 +1,6 @@
# @(#)Makefile 8.1 (Berkeley) 6/6/93
PROG= users
+WARNS?= 2
.include <bsd.prog.mk>
diff -ru /usr/src/usr.bin/users.orig/users.c /usr/src/usr.bin/users/users.c
--- /usr/src/usr.bin/users.orig/users.c Fri Aug 27 21:07:14 1999
+++ /usr/src/usr.bin/users/users.c Fri Aug 31 15:58:20 2001
@@ -117,5 +117,8 @@
scmp(p, q)
const void *p, *q;
{
- return(strncmp((char *)p, (char *)q, UT_NAMESIZE));
+ const char *const pp1 = p;
+ const char *const pp2 = q;
+
+ return(strncmp(pp1, pp2, UT_NAMESIZE));
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010831160414.7125e88e.david>