Date: Wed, 19 Sep 2001 20:32:40 +0900 (JST) From: Toshihiko ARAI <toshi@jp.FreeBSD.org> To: nate@yogotech.com (Nate Williams) Cc: freebsd-mobile@FreeBSD.org Subject: Re: [PATCH] pccard_ether and removable_* variables Message-ID: <200109191132.f8JBWeM88990.toshi@jp.FreeBSD.org> In-Reply-To: <15270.11733.309708.185928@nomad.yogotech.com> References: <15245.13394.275183.61715@nomad.yogotech.com> <200109011153.f81BrZL93078.toshi@jp.FreeBSD.org> <15253.10889.977127.513674@nomad.yogotech.com> <200109051230.f85CUGQ39840.toshi@jp.FreeBSD.org> <15254.22900.863293.94059@nomad.yogotech.com> <200109071244.f87Cib011728.toshi@jp.FreeBSD.org> <15256.60442.758729.299336@nomad.yogotech.com> <200109141452.f8EEqJF33125.toshi@jp.FreeBSD.org> <15266.6852.389169.298534@nomad.yogotech.com> <200109160641.f8G6fxf55588.toshi@jp.FreeBSD.org> <15270.11733.309708.185928@nomad.yogotech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
+ <15270.11733.309708.185928@nomad.yogotech.com>, Nate Williams wrote: >> http://home.jp.FreeBSD.org/~toshi/pccard-current-20010916.diff >> http://home.jp.FreeBSD.org/~toshi/pccard-stable-20010916.diff > The only difference I might make it to have the static_routes_{if} > defined in the pccard section, since otherwise it might make things > confusing for non-removalbe users. > #static_routes_ed0="net1" # Set to static route list for ed0 by > # removable network interface. > Would it be possible/advisable to rename this variable to something like > 'removable_route_{if}' instead? That way it wouldn't be confused with > entries used for non-removable interfaces? I did not notice the risk. I consider this change to be good. -- Toshihiko ARAI To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109191132.f8JBWeM88990.toshi>