Date: Tue, 4 Dec 2001 11:57:01 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: Bernd Walter <ticso@cicely8.cicely.de>, cjclark@alum.mit.edu, Mark Hannon <markhannon@optushome.com.au>, bugs-followup@FreeBSD.ORG, hackers@FreeBSD.ORG Subject: Re: bin/32261: dump creates a dump file much larger than sum of dumped files Message-ID: <200112041957.fB4Jv1j20226@apollo.backplane.com> References: <200112041339.aa05506@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:In message <20011204135626.A75212@cicely8.cicely.de>, Bernd Walter writes:
:>> Is there any reason we don't want to truncate the file? Does O_TRUNC
:>> not work well of the file is a tape device or something?
:>
:>I don't expect O_TRUNK to work on devices such tapes and disks.
:
:Well, it won't achieve anything on tapes or disk devices, but it
:should be completely harmless to add the O_TRUNC flag. The current
:behaviour is likely to be unexpected and cause confusion so it
:might as well be changed. I'll commit this later unless someone
:can think of a good reason not to.
:
:Ian
Woa! That sounds like a bad idea to me. If you want to do it right
then open(), fstat(), and only if the stat says it is a regular file
do you then ftruncate(). Passing O_TRUNC to a tape device may be ignored
by us, but it's not a valid flag to pass to a tape device and we shouldn't
do it.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200112041957.fB4Jv1j20226>