Date: Sat, 16 Feb 2002 22:54:51 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Alfred Perlstein <bright@mu.org>, Poul-Henning Kamp <phk@critter.freebsd.dk>, arch@FreeBSD.ORG, jhb@FreeBSD.ORG, peter@wemm.org, jake@locore.ca Subject: Re: gettimeofday() and crhold()/crfree() (was Re: gettimeofday() Message-ID: <200202170654.WAA44493@InterJet.elischer.org>
next in thread | raw e-mail | index | archive | help
and copyout(). Is copyout() MPSAFE on non-i386 archs? ) In-Reply-To: <200202170641.g1H6fRb43456@apollo.backplane.com> Message-ID: <Pine.BSF.4.21.0202162252490.39539-100000@InterJet.elischer.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 16 Feb 2002, Matthew Dillon wrote: > > :the whole point is moot.. > :you don't need to get or drop the creds at all.. > : > :see the attached patch I'm about to commit a version of.. > > I like it in general, but I don't like INVARIANTS causing so much grief > in the SMP path. If the whole point is to not drop the ucred in the > syscall then we shouldn't drop it whether INVARIANTS is set or not. > I would like to see the invariants sections simply removed. > > I like to run with INVARIANTS set, even on production systems, because > I like the extra assertions it makes. I agree but jhb wants to have it that way... He wants to be able to catch anyone accessing the ucred of a thread that is in user space. I personally think we should just remove the code. > > In anycase, I am going to go ahead and commit the mutex pool part of > my patch to cut down on the size of the ucred structure. Then I'm going > to go through and see if we do any other messing around with credentials > (like in the NFS code) to determine if removing Giant is still necessary. > > -Matt > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202170654.WAA44493>