Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Mar 2002 19:26:24 +0100
From:      Jens Schweikhardt <schweikh@schweikhardt.net>
To:        Garance A Drosihn <drosih@rpi.edu>
Cc:        freebsd-audit@FreeBSD.ORG, joerg@FreeBSD.ORG
Subject:   Re: crontab changes for PR bin/22612; please comment
Message-ID:  <20020320192624.A1258@schweikhardt.net>
In-Reply-To: <p05101502b8bc01b04024@[128.113.24.47]>; from drosih@rpi.edu on Mon, Mar 18, 2002 at 04:08:04PM -0500
References:  <20020318130904.A3869@schweikhardt.net> <p05101502b8bc01b04024@[128.113.24.47]>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 18, 2002 at 04:08:04PM -0500, Garance A Drosihn wrote:
# At 1:09 PM +0100 3/18/02, Jens Schweikhardt wrote:
# >hello, world\n
# >
# >please comment on this patch (slightly different from the
# >one in the PR
# >http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/22612)
# >
# >Currently, checking for modification of the tmp file just
# >looks at the mtime and gives a false "no modification" if
# >the edit took less than 1 second. This is solved by simply
# >comparing the whole struct stat.
...
# Stupid brain-dead alternative fix:
#    Create the file.  stat the file.  sleep a second.
#    *Then* open the file in the user's editor.  Any
#    change that they make will have to have been done
#    more than a second later.

Hmm. What about completely removing the test whether the tmp file was
modified? Just try to install the crontab, no matter what. Or is there a
reason why crontab files must not be installed if they havn't changed?

Regards,

	Jens
-- 
Jens Schweikhardt http://www.schweikhardt.net/
SIGSIG -- signature too long (core dumped)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020320192624.A1258>