Date: Wed, 22 May 2002 21:38:53 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jake Burkholder <jake@locore.ca> Cc: Ruslan Ermilov <ru@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c Message-ID: <20020522211222.X9440-100000@gamplex.bde.org> In-Reply-To: <20020520144919.D62759@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 20 May 2002, Jake Burkholder wrote:
> Apparently, On Mon, May 20, 2002 at 08:24:31PM +0300,
> Ruslan Ermilov said words to the effect of;
>
> > On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote:
> > > On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote:
> > > > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700,
> > > > Ruslan Ermilov said words to the effect of;
> > > >
> > > > > ru 2002/05/20 00:56:40 PDT
> > > > >
> > > > > Modified files:
> > > > > usr.bin/elf2aout elf2aout.c
> > > > > Log:
> > > > > s/u_int/u_int32_t/
> > > >
> > > > I would have preferred you to not commit this, it does nothing.
> > > >
> > > It makes code more MI, as u_int is not guaranteed to be 32 bit.
> > > This also makes it explicit that we're dealing with the elf32
> > > here, not elf64.
> > >
> > These would even better be declared using the Elf32_* types.
> > Could you please fix this?
>
> Umm, its an a.out header. u_int{,32_t} is correct.
Actually, a fixed-width unsigned integer type with the same number of
bits as `unsigned long' on the target machine is correct, since the
type in a target struct exec is `unsigned long' (see <sys/imgact.h>).
`unsigned long' for all targets is inconvenient for cross-compiling
and gratuitously compiler-dependent, but it was almost as good as
possible since it was the largest integer type. `u_int' for all targets
would be just broken since it might be 16 bits.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020522211222.X9440-100000>