Date: Wed, 26 Jun 2002 19:23:58 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c Message-ID: <20020626152357.GA30110@nagual.pp.ru> In-Reply-To: <200206261417.g5QEHTjR074759@freefall.freebsd.org> References: <200206261417.g5QEHTjR074759@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 26, 2002 at 07:17:28 -0700, Dag-Erling Smorgrav wrote: > des 2002/06/26 07:17:28 PDT > > Modified files: > crypto/openssh-portable session.c > Log: > Set basic environment variables before calling setusercontext(3) so that > it can override them. It becomes better, but not completely. What about this two left: TERM & PATH? About PATH: it seems that you expect that setusercontext() will set it, but setusercontext() can fail (its return code currently not checked, but was checked in our old code). It leaves code flow with no PATH. Better to set PATH before it & check its return code too. I am not sure about failure reaction, it can be fatal or just warning. About TERM: see "term" variable in login.conf(5) - sshd must not override it and follow the way login does. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020626152357.GA30110>