Date: Fri, 12 Jul 2002 01:06:08 -0700 From: Alfred Perlstein <bright@mu.org> To: Thomas Quinot <thomas@cuivre.fr.eu.org> Cc: bde@freebsd.org, audit@freebsd.org Subject: Re: trpt cleanup Message-ID: <20020712080608.GI97638@elvis.mu.org> In-Reply-To: <20020712100010.B50744@melusine.cuivre.fr.eu.org> References: <20020711224521.GD97638@elvis.mu.org> <20020712100010.B50744@melusine.cuivre.fr.eu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Thomas Quinot <thomas@cuivre.fr.eu.org> [020712 01:00] wrote:
> Le 2002-07-12, Alfred Perlstein écrivait :
>
> > -struct nlist nl[] = {
> > +struct nlist nl[3];
> > #define N_TCP_DEBUG 0
> > - { "_tcp_debug" },
> > #define N_TCP_DEBX 1
> > - { "_tcp_debx" },
> > - { "" },
> > -};
>
> This change, and the corresponding initialization added to main(),
> is questionable. Having an explicit element count, rather than an
> initializer, for nl means that the information of many elements there
> are in nl is sprinkled all over the place (here where nl is declared,
> and then also at the place where the array is initialized), and that
> both places need to be kept consistent by hand. Keeping things
> consistent is a job that compilers do very well, but that programmers
> tend to botch from time to time: better leave it to the compiler.
Any suggestions for a workaround?
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020712080608.GI97638>