Date: Sat, 11 Jan 2003 23:50:42 -0800 From: Alfred Perlstein <bright@mu.org> To: Jake Burkholder <jake@locore.ca> Cc: Matthew Dillon <dillon@apollo.backplane.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <20030112075042.GE33821@elvis.mu.org> In-Reply-To: <20030112014644.F212@locore.ca> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112014644.F212@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
* Jake Burkholder <jake@locore.ca> [030111 22:46] wrote: > > Its unnecessary code churn. I wouldn't be surprised if struct file was > used all the place in 3rd party modules, especially MAC modules. Now > they either need an ugly compat define or ugly idfefs. Some of your commits > were to code that's externally maintained. We've broken compatibility with > external code before for compelling reasons. This is not a compelling reason. > > You obviously don't think this is important, I do. If no one else cares about > this I'll shut up now. I prefer Jake's idea of just removing the casts where they are unneeded. This adds unneeded complexity and renaming that we don't need. It also reduces diffs to what will be 5-stable. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030112075042.GE33821>