Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Jan 2003 17:02:17 -0600
From:      "Jacques A. Vidrine" <nectar@FreeBSD.org>
To:        Tim Robbins <tjr@FreeBSD.org>
Cc:        "M. Warner Losh" <imp@bsdimp.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/stdio gets.c
Message-ID:  <20030130230217.GA75768@opus.celabo.org>
In-Reply-To: <20030131092613.A48425@dilbert.robbins.dropbear.id.au>
References:  <200301301200.h0UC0Qfd081080@repoman.freebsd.org> <20030130.063524.24235010.imp@bsdimp.com> <20030131092613.A48425@dilbert.robbins.dropbear.id.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 31, 2003 at 09:26:13AM +1100, Tim Robbins wrote:
> On Thu, Jan 30, 2003 at 06:35:24AM -0700, M. Warner Losh wrote:
> 
> > In message: <200301301200.h0UC0Qfd081080@repoman.freebsd.org>
> >             "Tim J. Robbins" <tjr@FreeBSD.org> writes:
> > : tjr         2003/01/30 04:00:26 PST
> > : 
> > :   Modified files:
> > :     lib/libc/stdio       gets.c 
> > :   Log:
> > :   Remove runtime warning about gets().
> > 
> > Why?
> 
> Because it's tacky, redundant (we already warn at compile time)
> and not worth the space. NetBSD and BSD/OS removed it years ago.
> 
> If you disagree and would like me to back this out, tell me.
> I don't feel strongly enough about this to argue.

I'd like it backed out, but also find it hard to argue vehemently.  It
may be tacky, but so what --- applications should never use gets().
I don't find it redundant ... it is easy to miss warnings at compile
time yet this is a very dangerous function.  I'd be happy to see it
removed from libc, to be honest, if ISO C didn't require it.

Cheers,
-- 
Jacques A. Vidrine <nectar@celabo.org>          http://www.celabo.org/
NTT/Verio SME          .     FreeBSD UNIX     .       Heimdal Kerberos
jvidrine@verio.net     .  nectar@FreeBSD.org  .          nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030130230217.GA75768>