Date: Sun, 6 Jul 2003 17:32:16 -0700 From: Alfred Perlstein <bright@mu.org> To: Garance A Drosihn <drosih@rpi.edu> Cc: Philippe Charnier <charnier@FreeBSD.org> Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... Message-ID: <20030707003216.GI72093@elvis.mu.org> In-Reply-To: <p0521064ebb2e5c8dd5e7@[128.113.24.47]> References: <200307061244.h66CiBqg079835@repoman.freebsd.org> <p0521064ebb2e5c8dd5e7@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
* Garance A Drosihn <drosih@rpi.edu> [030706 16:17] wrote: > At 5:44 AM -0700 7/6/03, Philippe Charnier wrote: > >charnier 2003/07/06 05:44:11 PDT > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/lpr/lpd lpd.c > > [...etc...] > > Log: > > add FBSDID > > Speaking only for lpd, I wish you would not have added FBSDID. > I had started to add FBSDID to all the source files of > lpr & friends, and found that it was just annoying when I > then went to build lpr on other platforms. So, I switched > back to just plain 'rcsid[] ='. > > It also seems odd to me that you added it to only one source > file out of the dozens in usr.sbin/lpr. Is there some reason > that this one file stood out as needing FBSDID? Isn't there a common header where you can just add: #ifndef __FBSDID #define __FBSDID(s) struct __hack #endif ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030707003216.GI72093>