Date: Wed, 30 Jul 2003 23:55:38 +0200 From: Pierre Beyssac <pb@fasterix.frmug.org> To: freebsd-current@freebsd.org Cc: silby@freebsd.org Subject: Re: bug in big pipe code causing performance problems Message-ID: <20030730215538.GA1672@fasterix.frmug.org> In-Reply-To: <20030730213249.GA900@fasterix.frmug.org> References: <20030730213249.GA900@fasterix.frmug.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote:
> - if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) {
> + if (space > 0
> + && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) {
PS : not-so-obvious after all since the above is equivalent to
"(space > 0)" by itself, so I won't commit the above as is, and the
real fix might be something more complicated...
--
Pierre Beyssac pb@fasterix.frmug.org pb@fasterix.freenix.org
Free domains: http://www.eu.org/ or mail dns-manager@EU.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030730215538.GA1672>