Date: Tue, 20 Jan 2004 07:59:12 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Ruben de Groot <mail25@bzerk.org> Cc: current@freebsd.org Subject: Re: REVIEW: cleanvar.patch Message-ID: <20040120155912.GA18837@Odin.AC.HMC.Edu> In-Reply-To: <20040120090953.GA25898@ei.bzerk.org> References: <98643.1074545359@critter.freebsd.dk> <20040120090953.GA25898@ei.bzerk.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jan 20, 2004 at 10:09:53AM +0100, Ruben de Groot wrote:
> On Mon, Jan 19, 2004 at 09:49:19PM +0100, Poul-Henning Kamp typed:
>=20
> [...]
>=20
> > +# If we do not have a writable /var, create a memory
> > +# filesystem for /var. We don't have /usr yet so
> ^^^^^^^^^^^^^^^^^^^
> > +# use mkdir instead of touch to test. We want mount
> > +# to record its mounts so we have to make sure /var/db
> > +# exists before doing the mount -a.
> > +#
> > +
> > +if (/bin/mkdir /var/.diskless 2> /dev/null); then
> > + rmdir /var/.diskless
> > +else
> > + mkdir -p /var
> > + mount_md ${varsize:=3D32m} /var
> > +fi
> > +
> > +# Populate /var if it looks empty
> > +if [ -d /var/run -a -d /var/db -a -d /var/empty ] ; then
> > + true
> > +else
> > + /usr/sbin/mtree -deU -f /etc/mtree/BSD.var.dist -p /var > /dev/null 2=
>&1
> ^^^^^^^^^^^^^^^
> Where did we get /usr ?
In rc.d/diskless, we run a mount -a before we get here which would be
inappropriate in this case.
In most cases we do have /usr since this comes after mountcritlocal
which mounts all local file systems. Only the case of a remote /usr
seperate from / doesn't work here. I think there's some argument that
we should move mtree and possiably newsyslog to /sbin to support the
population of /var.
-- Brooks
--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
--9jxsPFA5p3P2qPhR
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFADVBPXY6L6fI4GtQRAjELAJ0WSCgI9KqRd42EO4AnLu3wO1/XYQCg0v5W
yj5ZE91CYGCquzNjHVq/2fk=
=f59Y
-----END PGP SIGNATURE-----
--9jxsPFA5p3P2qPhR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040120155912.GA18837>