Date: Thu, 16 Sep 2004 04:02:13 -0000 From: Andrew Thompson <andy@fud.org.nz> To: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: pfflowd port Message-ID: <20040224012947.GA99698@kate.fud.org.nz> In-Reply-To: <200402240135.55752.max@love2party.net> References: <20040224001503.GA99464@kate.fud.org.nz> <200402240135.55752.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 24, 2004 at 01:35:55AM +0100, Max Laier wrote: > On Tuesday 24 February 2004 01:15, Andrew Thompson wrote: > > Hi all, > > > > I have created a port for pfflowd and thought i'd get feedback before > > submitting a PR. > > > > It can be found @ > > > > http://www.fud.org.nz/pfflowd-port.tar.gz >=20 > Okay, some feedback: > 1) You copied from security/pf (which is okay), but you should update t= he=20 > pkg-descr. oops, my bad. > 2) pkg-plist is empty, but should contain: > sbin/pfflowd > etc/rc.d/pfflowd.sh.sample oops again :) > 3) Not sure what the patch for pfflowd.c should do. What is wrong with = the=20 > check for invalid ports? It generated a gcc warning, as addr->sin_port is a uint16_t which cant be negative or >65536. -Werror made this fatal. > 4) Maybe get the pidfile.{c,h} from us (include/support/) and add them=20 > instead of just removing <util.h> and pidfile support. Thanks, I wasnt sure where pidfile() came from. Andy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040224012947.GA99698>