Date: Thu, 3 Jun 2004 16:29:44 +0200 From: Maxime Henrion <mux@freebsd.org> To: Christian Weisgerber <naddy@mips.inka.de> Cc: freebsd-current@FreeBSD.org Subject: Re: Network driver jumbo patch (affects multicast) Message-ID: <20040603142944.GJ9228@elvis.mu.org> In-Reply-To: <20040603140245.GA79548@kemoauc.mips.inka.de> References: <c9ltb3$13cb$1@kemoauc.mips.inka.de> <20040603012501.GA5035@thingy.tbd.co.nz> <20040603140245.GA79548@kemoauc.mips.inka.de>
index | next in thread | previous in thread | raw e-mail
Christian Weisgerber wrote: > Andrew Thompson: > > > You have removed the following comment from if_xl.c. The two notes are > > still relevant, should they stay? > > > > - * Note: the 3c905B currently only supports a 64-bit hash table, > > - * which means we really only need 6 bits, but the manual indicates > > - * that future chip revisions will have a 256-bit hash table, > > - * hence the routine is set up to calculate 8 bits of position > > - * info in case we need it some day. > > - * Note II, The Sequel: _CURRENT_ versions of the 3c905B have a > > - * 256 bit hash table. This means we have to use all 8 bits regardless. > > - * On older cards, the upper 2 bits will be ignored. Grrrr.... > > I think it's just rambling. I tend to disagree, I find this comment a valuable technical information. This is one very cool thing with Bill Paul drivers, they are very well commented, and I don't think we should change that. At the very least, this change should be separate to the one that uses the new multicast hash functions. Cheers, Maximehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040603142944.GJ9228>