Date: Fri, 11 Jun 2004 17:20:19 +0200 From: Jens Schweikhardt <schweikh@schweikhardt.net> To: Luigi Rizzo <rizzo@icir.org> Cc: hackers@freebsd.org Subject: Re: indent bugfix / added features Message-ID: <20040611152019.GA5028@schweikhardt.net> In-Reply-To: <20040611072615.A96657@xorpc.icir.org> References: <20040611025307.GG17367@teleri.net> <20040611140740.GA3355@schweikhardt.net> <20040611072615.A96657@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 11, 2004 at 07:26:15AM -0700, Luigi Rizzo wrote: # On Fri, Jun 11, 2004 at 04:07:40PM +0200, Jens Schweikhardt wrote: # > On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote: # ... # > # normalize the code a bit. In doing so I discovered a few deficencies in # > # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I # > # thought these might be fairly common wishes (and one of them is a # > # bugfix) and have attached a patch which does the following: # ... # > # I don't know if anyone would be interested in committing the bugfix (I # > # believe it is correct) or added features, but I hope someone else finds # > # this useful. # ... # > I'm willing to commit this if you could demonstrate that it will not # > produce different output in the default case than it does now. Say, # > run the old an new versions against the FreeBSD src tree and make a diff # > which should vanish apart from the bug-fixing effects. If you want to # > make yourself known as a quality software engineer, do the same for # > various sets of indent options :-) # # ?? this sounds like an absurd request, please... Sigh. A request for a little bit of QA and an emoticon as well and I'm criticised. I remember when I was not yet a committer that the better I could demonstrate that the code has no ill-effect the more chances some committer would bring it in the tree. # First, for a small patch like this you are much better off looking # at the source code diffs rather than checking the output in a # necessarily small set of test cases. I've looked at too many "innocous" patches that performed unexpectedly when run, to not let myself get away with this. Of course this may be because I'm not a good C programmer. # Second, either you trust the author (in which case his statement # "I believe is correct" is all you need), or you don't, in which # case you'd have to check the patch yourself in whatever way you # believe suitable. Either way, I don't see how the additional # tests you are asking for would change your behaviour. They'd improve my confidence of not having to backout someone else's patch. I was making my proposal on the premise that doing this test would not be very difficult or time consuming, and that the author, who apparently used indent a lot, would know better where potential pitfalls are (like option combos). If I can get any other committer's opinion saying "go ahead, commit", that's fine and I'll get to it ASAP. No hard feelings, Luigi :-) Regards, Jens -- Jens Schweikhardt http://www.schweikhardt.net/ SIGSIG -- signature too long (core dumped)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040611152019.GA5028>