Date: Sun, 27 Jun 2004 19:40:40 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: FreeBSD current users <current@freebsd.org> Subject: Re: jail getfsstat patches. Message-ID: <20040627174040.GM12007@darkness.comp.waw.pl> In-Reply-To: <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net> References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org> <20040627065932.GH12007@darkness.comp.waw.pl> <20040627101951.GJ12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net> <20040627160959.GL12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--CVsfbEDr348T3/Se Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 27, 2004 at 05:29:23PM +0000, Bjoern A. Zeeb wrote: +> some more points while skipping through the code a second time: +>=20 +> * could we make this +> strlcpy(sp->f_mntonname, "<restricted>", +> s.th. w/o '<' and '>' ? [] or () would make me feel better as +> those though special characters won't redirect anything in sh +> even if we should never see this. Ok, will do. +> * in fhstatfs you missed a prison_enforce_statfs call Nope. It is placed in cvtstatfs(). +> * some spelling/grammer left to someone else Yeah. +> else looks good to me; didn't check the compat code; +> going to see if I can build a kernel and setup some jails on a +> test machine to see if it works as well. Thanks! --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --CVsfbEDr348T3/Se Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA3waYForvXbEpPzQRAtbTAKDDoQRnpLkqmXD5908ahCzzatO/gwCeMs64 u0FquFJToNV0L75C75CMWrM= =1I92 -----END PGP SIGNATURE----- --CVsfbEDr348T3/Se--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040627174040.GM12007>