Date: Sun, 31 Jul 2005 16:26:25 +0200 From: Christian Brueffer <chris@unixpages.org> To: current@freebsd.org Subject: [PATCH] fwip(4) panic on attach Message-ID: <20050731142625.GC1190@unixpages.org>
next in thread | raw e-mail | index | archive | help
--eheScQNz3K90DVRs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
in CURRENT and RELENG_6 I get a reproducible panic with fwip(4) when
plugging in my firewire cardbus card. The following patch fixes it,
but I'm not sure if it's correct.
The interface works after applying the patch.
Index: if_fwip.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /data/ncvs/freebsd/src/sys/dev/firewire/if_fwip.c,v
retrieving revision 1.7
diff -u -r1.7 if_fwip.c
--- if_fwip.c 10 Jun 2005 16:49:08 -0000 1.7
+++ if_fwip.c 31 Jul 2005 14:01:52 -0000
@@ -171,11 +171,13 @@
=20
fwip =3D ((struct fwip_softc *)device_get_softc(dev));
unit =3D device_get_unit(dev);
+ =20
+ bzero(fwip, sizeof(struct fwip_softc));
+
ifp =3D fwip->fw_softc.fwip_ifp =3D if_alloc(IFT_IEEE1394);
if (ifp =3D=3D NULL)
return (ENOSPC);
=20
- bzero(fwip, sizeof(struct fwip_softc));
/* XXX */
fwip->dma_ch =3D -1;
- Christian
--=20
Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org
GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc
GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D
--eheScQNz3K90DVRs
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFC7N+RbHYXjKDtmC0RApnwAKDde5C59jf3ClLDyIhIxA7org+lVgCg3oiL
/kOFAtFPCLoPciPk8Nbhr3k=
=OXHA
-----END PGP SIGNATURE-----
--eheScQNz3K90DVRs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050731142625.GC1190>