Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Mar 2006 20:22:07 +1100
From:      Peter Jeremy <peterjeremy@optushome.com.au>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        arch@freebsd.org
Subject:   Re: Fw: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c
Message-ID:  <20060308092207.GB679@turion.vk2pj.dyndns.org>
In-Reply-To: <20060307.233728.42821161.imp@bsdimp.com>
References:  <20060307.233728.42821161.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote:
>This is the first commit of many to do what the comment says.
...
>  Log:
>  Remove leading __ from __(inline|const|signed|volatile).  They are
>  obsolete.  This should reduce diffs to NetBSD as well.

K&R function definitions are even more obsolete but still used
throughout the kernel.  IMHO, potential diff-reduction to NetBSD
seems a fairly flimsy reason for a significant amount of churn.

Also, any diff reduction with NetBSD is probably outweighed by
the diff increase with other FreeBSD branches.

Maybe this should be treated like whitespace cleanup - something to
do if you're going to be doing something non-trivial in the source
file.  (There are probably other cleanups in the same category).

-- 
Peter Jeremy



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060308092207.GB679>