Date: Fri, 4 Aug 2006 22:21:23 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Joao Barros <joao.barros@gmail.com> Cc: freebsd-hackers@FreeBSD.org, Julian Elischer <julian@FreeBSD.org> Subject: Re: [PATCH] add header "pppoe:" in ng_pppoe.c printfs Message-ID: <20060804182123.GH96644@cell.sick.ru> In-Reply-To: <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com> References: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com> <20060804150302.GD96644@cell.sick.ru> <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 04, 2006 at 04:48:49PM +0100, Joao Barros wrote: J> On 8/4/06, Gleb Smirnoff <glebius@freebsd.org> wrote: J> >On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote: J> >J> Being this a cryptic message to say the least and to probably save J> >J> someone some time when presented with this message I attach a patch J> >J> that adds the header "pppoe:" in every printf that didn't have it, J> >J> making it consistent with the rest of the file. J> > J> >I've attached a patch that cleans a bit logging in ng_pppoe. It changes J> >all printf(9) to log(9). The latter is better since it spams console J> >less, if event occurs many times per second. Also I've made the messages J> >more clear - prepended node ID where possible, function name when it J> >starts with ng_pppoe, or just "ng_pppoe". J> > J> >Can you please try out this patch and tell whether you like it. If you J> >do I will commit it soon. J> J> Hi, J> J> I've looked at the patch and it looks ok. J> It serves the purpose: make the messages more clear with the added J> bonus of more info. J> Thanks for taking the time to look into this :-) Since I don't use ng_pppoe now much, I'd appreciate if you do at brief test of this patch, before I commit it. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060804182123.GH96644>