Date: Fri, 19 Jan 2007 01:51:22 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 112957 for review Message-ID: <20070119.015122.514366110.imp@bsdimp.com> In-Reply-To: <200701152255.l0FMtKId033379@repoman.freebsd.org> References: <200701152255.l0FMtKId033379@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200701152255.l0FMtKId033379@repoman.freebsd.org>
Hans Petter Selasky <hselasky@freebsd.org> writes:
: ==== //depot/projects/usb/src/sys/dev/pccbb/pccbb.c#3 (text+ko) ====
:
: @@ -302,10 +302,11 @@
: * for the kldload/unload case to work. If we failed to do that, then
: * we'd get duplicate devices when cbb.ko was reloaded.
: */
: - device_get_children(brdev, &devlist, &numdevs);
: - for (tmp = 0; tmp < numdevs; tmp++)
: - device_delete_child(brdev, devlist[tmp]);
: - free(devlist, M_TEMP);
: + if (!device_get_children(brdev, &devlist, &numdevs)) {
: + for (tmp = 0; tmp < numdevs; tmp++)
Actually this is a problem. While the old code ignores errors, I
don't think that's really the right thing to do here. It is critical
that the children be deleted.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070119.015122.514366110.imp>