Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2007 16:36:11 +0900
From:      Pyun YongHyeon <pyunyh@gmail.com>
To:        freebsd-current@FreeBSD.org
Subject:   Call for re(4) checksum offload testers.
Message-ID:  <20070122073611.GC29223@cdnetworks.co.kr>

next in thread | raw e-mail | index | archive | help

--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

It seems that some revisions of re(4) hardwares(PCIe variants?) still
have Tx checksum offload issues. One user reported the issue said
the attached patch fixed the issue on his box.
Since there are lots of hardwares supported by re(4) I'd like to know
whether the attached patch has no other regressions on re(4) hardwares.
If there are no objections I'll commit it in a week.

Thanks.
-- 
Regards,
Pyun YongHyeon

--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="if_re.csum.patch"

Index: if_rlreg.h
===================================================================
RCS file: /home/ncvs/src/sys/pci/if_rlreg.h,v
retrieving revision 1.64
diff -u -r1.64 if_rlreg.h
--- if_rlreg.h	16 Jan 2007 20:35:23 -0000	1.64
+++ if_rlreg.h	20 Jan 2007 05:05:21 -0000
@@ -443,7 +443,12 @@
 #define RL_RX_BUF_SZ		RL_RXBUF_64
 #define RL_RXBUFLEN		(1 << ((RL_RX_BUF_SZ >> 11) + 13))
 #define RL_TX_LIST_CNT		4
-#define RL_MIN_FRAMELEN		60
+/*
+ * re(4) hardware IPv4 Tx checksum offload could be mangled with 28 bytes
+ * or less IP packets.
+ */
+#define RL_TXCSUM_MINLEN	28
+#define RL_MIN_FRAMELEN		(ETHER_HDR_LEN + RL_TXCSUM_MINLEN)
 #define RL_TXTHRESH(x)		((x) << 11)
 #define RL_TX_THRESH_INIT	96
 #define RL_RX_FIFOTHRESH	RL_RXFIFO_NOTHRESH

--R3G7APHDIzY6R/pk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070122073611.GC29223>