Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Jul 2007 16:11:45 -0600 (MDT)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        attilio@FreeBSD.org
Cc:        julian@elischer.org, current@FreeBSD.org
Subject:   Re: crash in tty code in 6.1.. fixed since?
Message-ID:  <20070713.161145.1324584079.imp@bsdimp.com>
In-Reply-To: <46972B28.1010409@FreeBSD.org>
References:  <46970DF7.3000803@elischer.org> <46972B28.1010409@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <46972B28.1010409@FreeBSD.org>
            Attilio Rao <attilio@FreeBSD.org> writes:
: I think it has been fixed some months ago IIRC.
: The problem here, should be that if sx_slock() let thread sleep, Giant 
: is released before to sleep and tp->t_session can be accessed in racy way.
: Another nice side-effect about having tty Giant :)

I've been having crashes right and left in cblock code.  I've had good
luck converting it to using a mutext.  However, someone else was
telling me they had big problems going all the way and locking the
entire TTY subsystem.  The evidence is in p4...

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070713.161145.1324584079.imp>