Date: Thu, 28 Feb 2008 23:02:21 -0600 From: Alec Kloss <alec-keyword-freebsd.org.a6e2e4@SetFilePointer.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: afs@freebsd.org, Tomas Olsson <tol@stacken.kth.se> Subject: Re: PERFORCE change 136345 for review (fwd) Message-ID: <20080229050221.GB67238@hamlet.SetFilePointer.com> In-Reply-To: <20080229041706.GA67238@hamlet.SetFilePointer.com> References: <20080227115148.W61020@fledge.watson.org> <20080229041706.GA67238@hamlet.SetFilePointer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2008-02-28 22:17, wrote: > On 2008-02-27 11:54, Robert Watson wrote: > >=20 > > Tomas, > >=20 > > Following a CVS update from the Arla anoncvs, I needed the attached pat= ch=20 > > to build on FreeBSD. I still have the following further local changes = in=20 > > my tree still: > >=20 > > - Remove nnpfs_deb.h include from fs_local.h. > >=20 > > - Add /usr/include to various paths so that machine/whatever.h includes > > properly. > >=20 > > - #ifdef NNPFS_DEBUG around local variables in nnpfs_lk_info to avoid u= nused > > variables warning/error. >=20 > I've been playing with this some tonight. My current thought about > dealing with the "machine/whatever.h" includes is to copy the > pertinent headers out of the kernel sources (via $SYS) at the same > time configure generates vnode_if.h. Any thoughts about that > approach? It's kinda unfortunate that these headers aren't inside > a machine/ directory in /sys; then we could -I these directly from=20 > /sys. Does anyone have any idea how this used to work? >=20 > I haven't loked at the NNPFS_DEBUG related issues yet, but I will. =20 Hrm. I didn't have any problems building arla on -CURRENT after creating my machine/ hack. I suppose a symlink would be more appropriate than a copy for that. Robert, did you need your other changes to get Arla to compile, or were there just warnings you were itching to fix? It's time to shovel snow, but I'll be back at this tomorrow evening. If we can come to an agreement on the machine includes and the nnpfs_debug stuff, tomorrow night I should be able to implement whatever we decide on and update the ports accordingly. After that, I guess it's send-pr time for arla and the ports maintainers. :) (Oh yeah, my change is just this: oldothello% diff -u cf/*.orig cf/bsd-header-vnode-if-h.m4 --- cf/bsd-header-vnode-if-h.m4.orig 2008-02-28 23:01:01.000000000 -0600 +++ cf/bsd-header-vnode-if-h.m4 2008-02-28 22:42:32.000000000 -0600 @@ -25,6 +25,7 @@ awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -h awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -p awk -f $SYS/tools/vnode_if.awk $SYS/kern/vnode_if.src -q + ln -sf $SYS/$(uname -m)/include machine else AC_MSG_ERROR(unable to find any vnode_if script) fi oldothello% ) --=20 Alec Kloss alec@SetFilePointer.com IM: angryspamhater@yahoo.com PGP key at http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xA241980E "No Bunny!" -- Simon, from Frisky Dingo --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFHx5Hd2s33paJBmA4RAkCfAJ9IRau6Ts2xsGIB9Wd9V70TM6waFgCfYUJN H3CVVhrBaZbLgl4mxm2mejE= =su+6 -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080229050221.GB67238>