Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 May 2008 21:45:32 GMT
From:      Vincenzo Iozzo <snagg@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 141676 for review
Message-ID:  <200805152145.m4FLjW3L015582@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=141676

Change 141676 by snagg@snagg_macosx on 2008/05/15 21:45:23

	missing sync

Affected files ...

.. //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_ioctl.h#9 edit
.. //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_pipe.c#9 edit

Differences ...

==== //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_ioctl.h#9 (text) ====

@@ -49,7 +49,7 @@
 	pid_t		app_pid;
 	struct 	auditpipe_ioctl_preselect_event *app_auevents;
 	int		app_event_len;
-};
+}auditpipe_ioctl_preselect;
 
 struct auditpipe_ioctl_preselect_old {
 	au_id_t		aip_auid;
@@ -61,7 +61,7 @@
  */
 #define	AUDITPIPE_PRESELECT_MODE_TRAIL	1	/* Global audit trail. */
 #define	AUDITPIPE_PRESELECT_MODE_LOCAL	2	/* Local audit trail. */
-#define	AUDITPIPE_PRESELECT_MODE_SYSCALL	3 /* Events based audit trail */
+#define	AUDITPIPE_PRESELECT_MODE_EVENT	3 /* Events based audit trail */
 
 /*
  * Ioctls to read and control the behavior of individual audit pipe devices.

==== //depot/projects/soc2008/snagg-audit/sys/security/audit/audit_pipe.c#9 (text) ====

@@ -435,10 +435,6 @@
 	if (app != NULL) {
 		TAILQ_REMOVE(&ap->ap_preselect_list, app, app_list);
 		mtx_unlock(&audit_pipe_mtx);
-	}
-	
-	mtx_unlock(&audit_pipe_mtx);
-	if (app != NULL) {
 		for(i = 0; i < app->app_event_len; i++) 
 			free((app->app_auevents + i), M_AUDIT_PIPE_PRESELECT_EVENT);
 		free(app, M_AUDIT_PIPE_PRESELECT);	
@@ -559,7 +555,7 @@
 			return (au_preselect(event, class, &app->app_mask,
 			    sorf));
 	
-	case AUDITPIPE_PRESELECT_MODE_SYSCALL: 
+	case AUDITPIPE_PRESELECT_MODE_EVENT: 
 		app = audit_pipe_preselect_find_event(ap, event, app_pid, sorf);
 		if(app != NULL)
 			return (1);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805152145.m4FLjW3L015582>