Date: Wed, 28 Jan 2009 09:20:46 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: keramida@freebsd.org Cc: hackers@freebsd.org Subject: Re: Code review request: cdcontrol status label additon Message-ID: <20090128.092046.84362525.imp@bsdimp.com> In-Reply-To: <87k58f7npu.fsf@kobe.laptop> References: <20090128.020950.-1962670362.imp@bsdimp.com> <87k58f7npu.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <87k58f7npu.fsf@kobe.laptop>
Giorgos Keramidas <keramida@freebsd.org> writes:
: On Wed, 28 Jan 2009 02:09:50 -0700 (MST), "M. Warner Losh" <imp@bsdimp.com> wrote:
: > Please find enclosed patches to enable printing of the ISO-9660 Volume
: > label, if present, for a CD. I've connected this to the 'status
: > label' command. Please comment.
:
: The style looks ok, but this didn't work for a Fedora Core 10 disk I
: have around. glabel on the other hand detected the label fine:
:
: [ /var/log/messages ]
: Jan 28 11:59:00 kobe kernel: GEOM_LABEL: Label for provider acd0t01 is iso9660/F10-i686-Live.
:
: Running `status label' on the same disk didn't find one:
:
: # ./cdcontrol status label
: No ISO 9660 label found
: # ./cdcontrol -f /dev/acd0t01 status label
: No ISO 9660 label found
:
: Maybe it would be better to hook into glabel (when available) or use a
: userland copy of the same code?
Not going to look at glabel for this. I lifted the code from glable,
but must have done it badly. I'll grab a core 10 cd and see what's up.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090128.092046.84362525.imp>