Date: Sun, 01 Feb 2009 20:36:18 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: thompsa@FreeBSD.org Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet Message-ID: <20090201.203618.1640016624.imp@bsdimp.com> In-Reply-To: <20090201213749.GJ32503@citylink.fud.org.nz> References: <200902010650.n116obU1045871@svn.freebsd.org> <20090201.142808.886478999.imp@bsdimp.com> <20090201213749.GJ32503@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20090201213749.GJ32503@citylink.fud.org.nz>
Andrew Thompson <thompsa@FreeBSD.org> writes:
: On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote:
: > In message: <200902010650.n116obU1045871@svn.freebsd.org>
: > Andrew Thompson <thompsa@FreeBSD.org> writes:
: > : + locked = mtx_owned(&sc->sc_mtx);
: > : + if (!locked)
: > : + AUE_LOCK(sc);
: >
: > You do know this is racy, right?
:
: Yea... It only get called unlocked during mii probe+attach so its fine.
: I havnt actaully checked if its ok to hold a mutex during
: mii_phy_probe() which would make this go away.
You hold GIANT when probe+attach, which means I think you can't
acquire any other locks...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090201.203618.1640016624.imp>