Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Feb 2009 09:42:57 -1000 (HST)
From:      Jeff Roberson <jroberson@jroberson.net>
To:        Fabian Keil <freebsd-listen@fabiankeil.de>
Cc:        freebsd-net@freebsd.org
Subject:   Re: mbuf revision, testers/comments wanted.
Message-ID:  <20090202094226.E983@desktop>
In-Reply-To: <20090201170550.482bf325@fabiankeil.de>
References:  <20090131125100.N983@desktop> <20090201160544.4f1961b4@fabiankeil.de> <20090201170550.482bf325@fabiankeil.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 1 Feb 2009, Fabian Keil wrote:

> Fabian Keil <freebsd-listen@fabiankeil.de> wrote:
>
>> Jeff Roberson <jroberson@jroberson.net> wrote:
>>
>>> http://people.freebsd.org/~jeff/mbuf_ref2.diff
>>
>>> I have been experimenting with different revisions to the mbuf api to
>>> improve performance and simplify code.  This patch is the first of
>>> several proposed steps towards those goals.  The aim of this patch is
>>> two fold;
>>
>>> I would appreciate testing feedback from varied workloads to make sure
>>> there are no bugs before I go forward with this.  I have tested only
>>> host oriented networking with a few drivers.  It is not anticipated
>>> that there will be any significant incompatibilities introduced with
>>> this round but there is always that possibility.
>
>> 5)
>> Finally, I tested the patch on an IBM ThinPad R51. The kernel
>> hangs on boot, the last messages are (hand transcribed):
>>
>> iwi0: <Intel(R) PRO/Wireless 2200BG> mem 0xc0214000-0xc0214fff irq 11 at device 2.0 on pci2
>> iwi0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xc0214000
>> iwi0: could not allocate rx mbuf
>> iwi0: could not allocate Rx ring
>> bpfdetach: was not attached
>
> Never mind, kernel and user land weren't completely in
> sync and this might be related to the recent wlan commits.
> I'll retry with an up-to-date user land.
>

I have updated the patch here:

http://people.freebsd.org/~jeff/mbuf_ref2.diff

This resolves the !INVARIANTS bug and improves the style as you suggested.

Thanks,
Jeff

> Fabian
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090202094226.E983>