Date: Tue, 28 Apr 2009 13:55:10 +0200 From: Olivier Houchard <mlfbsd@ci0.org> To: Gavin Atkinson <gavin@freebsd.org> Cc: Channa <channa.kad@gmail.com>, freebsd-arm@freebsd.org Subject: Re: strncmp issue Message-ID: <20090428115510.GA98699@ci0.org> In-Reply-To: <1240918262.85945.1.camel@buffy.york.ac.uk> References: <515c64960904280252sc9fe2afy24e8db8ab13b13e4@mail.gmail.com> <1240918262.85945.1.camel@buffy.york.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 2009-04-28 at 15:22 +0530, Channa wrote:
> > Hi,
> >
> > I am using the freebsd implementation of strncmp for ARM which is an
> > assembly implementation.
> > I have a small doubt, when i tested the strncmp by passing the third argument:
> > 'n' as -1 the return values is '0' instead it should '-1'.
> > When the third argument to strncmp is as below:
> >
> > ret = strncmp("a","b",-1)
> >
> > I think the assembly implementation in
> > src/lib/libc/arm/string/strncmp.S file needs
> > to be modified to take care of the above condition.
> >
> > In the current implementation
> > /* if ((len - 1) < 0) return 0 */
> > subs r2, r2, #1
> > movmi r0, #0
> > RETc(mi)
> >
> > This should be changed to check as below
> >
> > /* if ((len ) < 0) return 0 */
> > /* Assembly code here */
> >
> > Could anyone help in solving the above issue.?
> >
Hi,
This shouldn't be an issue, as the second argument of strncmp is unsigned,
-1 is not a valid value.
Regards,
Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090428115510.GA98699>