Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2009 10:38:29 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Rene Ladan <r.c.ladan@gmail.com>
Cc:        freebsd-fs@freebsd.org
Subject:   Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll)
Message-ID:  <200907281038.30277.jhb@freebsd.org>
In-Reply-To: <e890cae60907280703v3cefb770j325876ab15030bcc@mail.gmail.com>
References:  <200907271400.n6RE05Rv056472@freefall.freebsd.org> <200907280941.32840.jhb@freebsd.org> <e890cae60907280703v3cefb770j325876ab15030bcc@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 28 July 2009 10:03:40 am Rene Ladan wrote:
> 2009/7/28 John Baldwin <jhb@freebsd.org>:
> > On Monday 27 July 2009 10:00:05 am Rene Ladan wrote:
> >> The following reply was made to PR kern/136945; it has been noted by=20
GNATS.
> >>
> >> From: Rene Ladan <rene@freebsd.org>
> >> To: John Baldwin <jhb@freebsd.org>
> >> Cc: bug-followup@freebsd.org
> >> Subject: Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll)
> >> Date: Mon, 27 Jul 2009 15:51:15 +0200
> >>
> >> =A02009/7/27 John Baldwin <jhb@freebsd.org>:
> >> =A0> I would actually expect this to be the correct order for these two
> > locks.=3D
> >> =A0 =3DA0Can
> >> =A0> you capture the output of the 'debug.witness.fullgraph' sysctl to=
 a=20
file?
> >> =A0>
> >> =A0Yes, see attachment. =A0I'm still running the same 8.0-BETA2.
> >
> > Hmm, the attachment was eaten by a grue, can you post the file somewher=
e?
> >
> Yes, see ftp://rene-ladan.nl/pub/freebsd/kern_136945.txt

Ok, it looks like it did encounter a UFS -> filedesc order at some point.  =
Can=20
you patch sys/kern/subr_witness.c to add a section to the order_lists[] arr=
ay=20
after the 'ZFS locking list' and before the spin locks list that looks like=
=20
this:

	{ "filedesc structure", &lock_class_sx },
	{ "ufs", &lock_class_lockmgr},
	{ NULL, NULL },

=2D-=20
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907281038.30277.jhb>