Date: Thu, 09 Dec 2010 10:13:39 -0800 From: Kirk McKusick <mckusick@mckusick.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-fs@freebsd.org, pjd@freebsd.org, Oliver Fromme <olli@lurza.secnetix.de> Subject: Re: TRIM support for UFS? Message-ID: <201012091813.oB9IDd2H078366@chez.mckusick.com> In-Reply-To: <20101209103411.GL33073@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Other than the nit pointed out by Pawel, the diffs look good to me. You should consider adding the -t option to newfs so that the TRIM option can be specified at the time the filesystem is created (as a general rule, anything you can do with tunefs should also be possible with newfs). I agree with your decision to let administrators opt-out of doing TRIM. If experience shows it to be generally useful to have it on, we can change the default to enabled later. If we do change the default to enabled, then we will want to delete the warning about TRIM not being supported by the underlying disk that you added at mount time as we would start getting a lot of them for all the non-SSD disks. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012091813.oB9IDd2H078366>