Date: Wed, 5 Jan 2011 20:36:53 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: John Baldwin <jhb@freebsd.org>, freebsd-current@freebsd.org, Erik Cederstrand <erik@cederstrand.dk> Subject: Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/ Message-ID: <20110105193653.GA49285@stack.nl> In-Reply-To: <20110105165545.GP23329@acme.spoerlein.net> References: <20110105131439.GN23329@acme.spoerlein.net> <4184C8F2-3C6D-46FB-8F10-DDEBA6DB1C35@cederstrand.dk> <AD2AEFFB-37A4-4DAB-9094-7289C1C8B0DD@cederstrand.dk> <201101050934.49845.jhb@freebsd.org> <20110105165545.GP23329@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 05, 2011 at 05:55:45PM +0100, Ulrich Spörlein wrote: > On Wed, 05.01.2011 at 09:34:49 -0500, John Baldwin wrote: > > These are all marked as __dead2, so the compiler should "know" that these do > > not return. > And clang did the right thing here in the past. Beware that it does no > inter-procedural analysis yet, so it will usually miss that usage() > calls exit unconditionally. > *But*, it should grok that for err(3) and exit(3). Now there are some > possible remedies: > - get IPA to work with clang, or at least file a bug > - mark functions as __dead2 (please don't do that) Why not? I have done this in some cases because it leads to better code with gcc (the system version in 9-current). See SVN commit r212508 to bin/sh/parser.c. Although synexpect() and synerror() are static, adding __dead2 to both makes the executable 576 bytes smaller on i386 (these functions are called many times). Adding __dead2 to synexpect() only causes a warning "noreturn function does return" (it calls synerror()). Adding __dead2 to synerror() only also makes the executable smaller but not as much as adding it to both. Reordering the functions in the file does not help to make gcc see that the functions do not return. > - come up with a way to mark the false positives (kinda impossible with > the way scan-build currently works) -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110105193653.GA49285>