Date: Wed, 9 Nov 2011 10:01:58 -0600 From: Brooks Davis <brooks@freebsd.org> To: Ryan Stone <rysto32@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] Allow syslogd to accept multiple configuration files Message-ID: <20111109160158.GA55645@lor.one-eyed-alien.net> In-Reply-To: <CAFMmRNx9z4TFdJAjcg7evj17n1w6VrNuh_gjWLgcwnfn3U0__Q@mail.gmail.com> References: <CAFMmRNx9z4TFdJAjcg7evj17n1w6VrNuh_gjWLgcwnfn3U0__Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 09, 2011 at 10:27:44AM -0500, Ryan Stone wrote: > I've written the following patch to allow syslogd to accept multiple > configuration files by passing multiple -f options. One use case for > this is to specify a common configuration file that applies across > multiple machines along with a second config file specific to the > local machine. >=20 > The patch can also be found at > http://people.freebsd.org/~rstone/patches/syslogd-multiconf.diff >=20 > (Oh, and before somebody asks, the reason that I converted struct > filed to use a TAILQ was that at one point I found myself typing > struct filed ***, then hit myself and refactored the code instead). I gave it a once over and it looks good. Do you happen to know why the code calloc's the struct filed's with 1's? I didn't do any investigation but that's seems like an odd pattern. -- Brooks --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFOuqP1XY6L6fI4GtQRAlQLAJ9fzlfiFObK0MxxaElThJnVbbGWiACdGSQw f8YRir4bysLeXALBme0WmPM= =nfG6 -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111109160158.GA55645>