Date: Fri, 16 Mar 2012 10:06:50 -0700 From: YongHyeon PYUN <pyunyh@gmail.com> To: Paul Guyot <paulguyot@ieee.org> Cc: freebsd-stable@freebsd.org Subject: Re: Changes brought to bce(4) disabling ipmi access during boot Message-ID: <20120316170650.GA6841@michelle.cdnetworks.com> In-Reply-To: <3D1680C7-39A2-47B9-BD40-A987238886EB@ieee.org> References: <8D3993D8-074E-45E6-8AF7-DB51369F33BD@ieee.org> <20120315171018.GA3295@michelle.cdnetworks.com> <3D1680C7-39A2-47B9-BD40-A987238886EB@ieee.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Thu, Mar 15, 2012 at 09:19:27AM +0100, Paul Guyot wrote:
> Le 15 mars 2012 ? 18:10, YongHyeon PYUN a ?crit :
>
> > On Wed, Mar 14, 2012 at 11:44:37PM +0100, Paul Guyot wrote:
> >> Hello,
> >>
> >> Changes brought to bce(4) prevents booting a R410 Dell server with GELI-encrypted root ZFS partition requiring a passphrase, something that was possible with 9-RELEASE.
> >>
> >> Using a binary search, the bug comes from the following revision:
> >>
> >> Updating collection src-all/cvs
> >> Edit src/sys/dev/bce/if_bce.c
> >> Add delta 1.89.2.4 2012.01.09.19.07.14 yongari
> >> Edit src/sys/dev/bce/if_bcereg.h
> >> Add delta 1.35.2.3 2012.01.09.19.07.14 yongari
> >> Shutting down connection to server
> >>
> >
> > Could you try attach patch and let me know whether it recovers IPMI
> > functionality?
>
> Thank you for your quick patch. Unfortunately, it does not recover IPMI functionality with STABLE@2012.01.09.19.08.00.
>
Hmm, how about this one?
--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="bce.ipmi.diff2"
Index: sys/dev/bce/if_bce.c
===================================================================
--- sys/dev/bce/if_bce.c (revision 232950)
+++ sys/dev/bce/if_bce.c (working copy)
@@ -1992,8 +1992,7 @@
ifp = sc->bce_ifp;
mii = device_get_softc(sc->bce_miibus);
- if (mii == NULL || ifp == NULL ||
- (ifp->if_drv_flags & IFF_DRV_RUNNING) == 0)
+ if (mii == NULL || ifp == NULL)
return;
sc->bce_link_up = FALSE;
@@ -2038,9 +2037,6 @@
}
}
- if (sc->bce_link_up == FALSE)
- return;
-
/* Set half or full duplex based on PHY settings. */
if ((mii->mii_media_active & IFM_GMASK) == IFM_HDX) {
DBPRINT(sc, BCE_INFO_PHY,
--+QahgC5+KEYLbs62--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120316170650.GA6841>