Date: Mon, 4 Jun 2012 17:33:58 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r236554 - projects/pf/head/sys/contrib/pf/net Message-ID: <20120604133358.GO44607@FreeBSD.org> In-Reply-To: <20120604210548.Y1459@besplex.bde.org> References: <201206041009.q54A9v4A019437@svn.freebsd.org> <20120604210548.Y1459@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 04, 2012 at 09:29:46PM +1000, Bruce Evans wrote: B> > Log: B> > Consistent names for pf(4) malloc(9) types. B> B> Many still have spaces in them. This breaks at least simple parsing B> of "vmstat -m" output using columns in awk (and postprocessing of B> vmstat -m output is more needed than orginally, since vmstat is now B> too stupid to even print the totals). A few bugs in this area have B> been fixed relatively recently. For example: B> B> file desc -> filedesc (matches original naming scheme -- no underscore) B> BIO buffer -> biobuf B> UFS mount -> ufs_mount (now just a style bug -- underscore) B> VM pgdata -> vm_pgdata B> * ihash -> [went away] B> struct cdev * -> [went away] B> cluster_save buffer -> [went away] (was also too long) B> [too many] -> [vmstat -z, with worse names and formatting] Should only the shortdesc not contain spaces? Well, there is conflict between parseability and understandability :) B> Now broken on ref10-i386: B> B> NFSCL diroffd B> NFS fh B> B> only. Also a lot of "CAM foo". -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120604133358.GO44607>