Date: Mon, 11 Jun 2012 07:17:59 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Warren Block <wblock@wonkity.com> Cc: ports@FreeBSD.org, Jason Helfman <jhelfman@e-e.com> Subject: Re: NOPORTDOCS and NOPORTEXAMPLES Message-ID: <20120611051759.GQ60433@ithaqua.etoilebsd.net> In-Reply-To: <alpine.BSF.2.00.1206101736170.78656@wonkity.com> References: <alpine.BSF.2.00.1206101408330.77586@wonkity.com> <f5dc8813da21631bff52d1017bcd6dcf.squirrel@mail.experts-exchange.com> <alpine.BSF.2.00.1206101736170.78656@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--l8yJEXo8J9fv7OFY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jun 10, 2012 at 06:05:49PM -0600, Warren Block wrote:
> On Sun, 10 Jun 2012, Jason Helfman wrote:
>=20
> >> So references to NOPORTDOCS should be replaced with references to
> >> PORT_OPTIONS:MDOCS now? Why that but not NOPORTEXAMPLES?
> >
> > You can use PORT_OPTIONS:MEXAMPLES for this case.
> >
> > I believe I did this recently in www/flot
>=20
> But only after bsd.port.options.mk is included. Here's what I was=20
> trying to do:
>=20
> .if ${PORT_OPTIONS:MDOCS}
> OPTIONS_DEFINE+=3D REFDOCS
> REFDOCS_DESC=3D Install the reference documents
> OPTIONS_DEFAULT+=3D REFDOCS
> .endif
>=20
> .if ${PORT_OPTIONS:MEXAMPLES}
> OPTIONS_DEFINE+=3D EXAMPLES
> EXAMPLES_DESC=3D Install the example code
> OPTIONS_DEFAULT+=3D EXAMPLES
> .endif
>=20
> .include <bsd.port.options.mk>
>=20
Why not simply that way:
OPTIONS_DEFINE=3D ... DOCS EXAMPLES
DOCS_DESC=3D Install the reference documents
And done.
Condtion an EXAMPLES on EXAMPLES options doesn't make sense to me.
by default DOCS and EXAMPLES are on expect if the user set NOPORTDOCS,
NOPORTEXAMPLES or OPTIONS_UNSET=3D DOCS EXAMPLES
regards,
Bapt
--l8yJEXo8J9fv7OFY
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAk/Vf4cACgkQ8kTtMUmk6EyxRgCgm799XIMHh4HqeAT/8kMZ0t8D
+GsAoLkN4GIVfj5vOSBa30sIXxTPluWa
=K4e/
-----END PGP SIGNATURE-----
--l8yJEXo8J9fv7OFY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120611051759.GQ60433>