Date: Thu, 29 Nov 2012 12:05:18 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Robert N. M. Watson" <rwatson@FreeBSD.org> Cc: freebsd-arch@FreeBSD.org Subject: Re: Print a (rate-limited) warning when UMA zone is full. Message-ID: <20121129110518.GF1370@garage.freebsd.pl> In-Reply-To: <0D8E588B-6FCB-4B01-9786-B5D42F16C3F0@FreeBSD.org> References: <20121129090147.GB1370@garage.freebsd.pl> <alpine.BSF.2.00.1211291027430.59662@fledge.watson.org> <20121129103752.GD1370@garage.freebsd.pl> <D7657157-0791-486D-8EF5-99488023E7ED@FreeBSD.org> <20121129105306.GE1370@garage.freebsd.pl> <0D8E588B-6FCB-4B01-9786-B5D42F16C3F0@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Nov 29, 2012 at 10:56:32AM +0000, Robert N. M. Watson wrote: > On 29 Nov 2012, at 10:53, Pawel Jakub Dawidek wrote: > > Agreed, especially if reaching those limits is expected by the > > administrator and he is not going to increase them. But in this case it > > would be even better to provide a way to turn them off. > > I wonder if each instance of a 'ratecheck' should come with an associated tunable/sysctl pair to allow suppression to be easily configured. I almost find myself wondering if we want something that looks a bit like our static SYSCTL/VFS_SET/etc declarations: > > static RATECHECK(..., "foo.bar.baz", ...); > > Unfortunately, the tunable/sysctl mismatch makes it slightly awkward since you'd need to declare both, but I think probably worthwhile. I'm afraid you lost me here. Tunable/sysctl name is not related in any way with the warning we are printing. How can you tell kern.ipc.maxsockets affects limits of eight different UMA zones? Also rate-limiting is not only used to print warnings, current ppsratecheck() function just answer the question if the limit should be enforced (something is happening too frequently) or not. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC3QW0ACgkQForvXbEpPzSulgCfRCPHzNfLeckghq92LSthW13d e6IAn3EkeJUrm3uCBZl0LD0XGnT5qBm/ =2pUI -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129110518.GF1370>